netdev - Re: [PATCH net-next] tcp: Set rcv zerocopy hint correctly if skb last frag is < PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80810ad7-a044-a88f-6032-0508661aadc2@gmail.com>
Date:   Sun, 15 Dec 2019 11:59:40 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Arjun Roy <arjunroy.kdev@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, arjunroy@...gle.com,
        soheil@...gle.com, edumazet@...gle.com
Subject: Re: [PATCH net-next] tcp: Set rcv zerocopy hint correctly if skb last
 frag is < PAGE_SIZE.



On 12/15/19 11:22 AM, Jakub Kicinski wrote:
> On Thu, 12 Dec 2019 14:59:30 -0800, Arjun Roy wrote:
>> At present, if the last frag of paged data in a skb has < PAGE_SIZE
>> data, we compute the recv_skip_hint as being equal to the size of that
>> frag and the entire next skb.
>>
>> Instead, just return the runt frag size as the hint.
> 
> nit: this commit message doesn't really tell us why or what the effects
>      are going to be.

Right, I added a bit of explanation.

Basically we would hint the application to copy more bytes than needed.

Since zerocopy is best effort, this can target net-next

> 
>> Signed-off-by: Arjun Roy <arjunroy@...gle.com>
>> Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> 
> WARNING: Missing Signed-off-by: line by nominal patch author 'Arjun Roy <arjunroy.kdev@...il.com>'
> 
> You gotta send it from the same address you signed it off from.

I sent a v2 on behalf of Arjun.

Thanks.