netdev - Re: [PATCH net-next] selftests/net: make so_txtime more robust to timer variance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191214180509.2dfd117d@cakuba.netronome.com>
Date:   Sat, 14 Dec 2019 18:05:09 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        Willem de Bruijn <willemb@...gle.com>,
        Naresh Kamboju <naresh.kamboju@...aro.org>
Subject: Re: [PATCH net-next] selftests/net: make so_txtime more robust to
 timer variance

On Thu, 12 Dec 2019 11:36:46 -0500, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@...gle.com>
> 
> The SO_TXTIME test depends on accurate timers. In some virtualized
> environments the test has been reported to be flaky. This is easily
> reproduced by disabling kvm acceleration in Qemu.
> 
> Allow greater variance in a run and retry to further reduce flakiness.
> 
> Observed errors are one of two kinds: either the packet arrives too
> early or late at recv(), or it was dropped in the qdisc itself and the
> recv() call times out.
> 
> In the latter case, the qdisc queues a notification to the error
> queue of the send socket. Also explicitly report this cause.
> 
> Link: https://lore.kernel.org/netdev/CA+FuTSdYOnJCsGuj43xwV1jxvYsaoa_LzHQF9qMyhrkLrivxKw@mail.gmail.com
> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied, thank you!