netdev - Re: [PATCH bpf-next] samples/bpf: Add missing -lz to TPROGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ+HfNjyx6ZLrcqW+voHsNH-PUuLKGCyvtdVXSz+kODhyxQYAA@mail.gmail.com>
Date:   Mon, 16 Dec 2019 13:16:20 +0100
From:   Björn Töpel <bjorn.topel@...il.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next] samples/bpf: Add missing -lz to TPROGS_LDLIBS

On Mon, 16 Dec 2019 at 11:24, Toke Høiland-Jørgensen <toke@...hat.com> wrote:
>
> Since libbpf now links against zlib, this needs to be included in the
> linker invocation for the userspace programs in samples/bpf that link
> statically against libbpf.
>
> Fixes: 166750bc1dd2 ("libbpf: Support libbpf-provided extern variables")
> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>

Thanks Toke!

Tested-by: Björn Töpel <bjorn.topel@...el.com>

> ---
>  samples/bpf/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
> index 1fc42ad8ff49..b00651608765 100644
> --- a/samples/bpf/Makefile
> +++ b/samples/bpf/Makefile
> @@ -196,7 +196,7 @@ endif
>
>  TPROGCFLAGS_bpf_load.o += -Wno-unused-variable
>
> -TPROGS_LDLIBS                  += $(LIBBPF) -lelf
> +TPROGS_LDLIBS                  += $(LIBBPF) -lelf -lz
>  TPROGLDLIBS_tracex4            += -lrt
>  TPROGLDLIBS_trace_output       += -lrt
>  TPROGLDLIBS_map_perf_test      += -lrt
> --
> 2.24.0
>