netdev - Re: [RESEND PATCH] kernel: bpf: add releases() annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191216150419.GB27202@linux.fritz.box>
Date:   Mon, 16 Dec 2019 16:04:19 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jules Irenge <jbi.octave@...il.com>
Cc:     bokun.feng@...il.com, ast@...nel.org, kafai@...com,
        songliubraving@...com, yhs@...com, andriin@...com,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] kernel: bpf: add releases() annotation

On Mon, Dec 16, 2019 at 12:42:39PM +0000, Jules Irenge wrote:
> Add sparse annotation to remove issue detected by sparse tool.
> warning: context imbalance in __bpf_prog_exit - unexpected unlock
> 
> Signed-off-by: Jules Irenge <jbi.octave@...il.com>
> ---
>  kernel/bpf/trampoline.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/bpf/trampoline.c b/kernel/bpf/trampoline.c
> index 7e89f1f49d77..fb43b7a57e38 100644
> --- a/kernel/bpf/trampoline.c
> +++ b/kernel/bpf/trampoline.c
> @@ -213,6 +213,7 @@ u64 notrace __bpf_prog_enter(void)
>  }
>  
>  void notrace __bpf_prog_exit(struct bpf_prog *prog, u64 start)
> +	__releases(RCU)

Hmm, why are you not adding an annotation to __bpf_prog_enter() as well ?

>  {
>  	struct bpf_prog_stats *stats;
>  
> -- 
> 2.23.0
>