netdev - [PATCH iproute2 v5 2/2] ip-link: Add white space to "xstats" display result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <OSBPR01MB3784E1EE94AB7FDC7D381C7D8E510@OSBPR01MB3784.jpnprd01.prod.outlook.com>
Date:   Mon, 16 Dec 2019 04:01:12 +0000
From:   "mizuta.takeshi@...itsu.com" <mizuta.takeshi@...itsu.com>
To:     "'netdev@...r.kernel.org'" <netdev@...r.kernel.org>,
        "'davem@...emloft.net'" <davem@...emloft.net>
CC:     "mizuta.takeshi@...itsu.com" <mizuta.takeshi@...itsu.com>
Subject: [PATCH iproute2 v5 2/2] ip-link: Add white space to "xstats" display
 result

Running "ip link xstats type bridge" shows the result of truncating white space.

  $ ip link xstats type bridge
  <snip>
                      IGMP reports:
                        RX: v1 0 v2 0 v3 0
                        TX: v1 0 v2 0v3 0

iproute2 v4 prints one line at a time, but iproute2 v5 prints one line at multiple times.
It seems that the white space in IGMP TX: was lost during this change.

Signed-off-by: MIZUTA Takeshi <mizuta.takeshi@...itsu.com>
---
 ip/iplink_bridge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
index 06f736d..868ea6e 100644
--- a/ip/iplink_bridge.c
+++ b/ip/iplink_bridge.c
@@ -742,7 +742,7 @@ static void bridge_print_stats_attr(struct rtattr *attr, int ifindex)
                        print_string(PRINT_FP, NULL, "%-16s      ", "");
                        print_u64(PRINT_ANY, "tx_v1", "TX: v1 %llu ",
                                  mstats->igmp_v1reports[BR_MCAST_DIR_TX]);
-                       print_u64(PRINT_ANY, "tx_v2", "v2 %llu",
+                       print_u64(PRINT_ANY, "tx_v2", "v2 %llu ",
                                  mstats->igmp_v2reports[BR_MCAST_DIR_TX]);
                        print_u64(PRINT_ANY, "tx_v3", "v3 %llu\n",
                                  mstats->igmp_v3reports[BR_MCAST_DIR_TX]);
--
2.24.0