netdev - Re: [PATCH bpf-next v2] libbpf: Print hint about ulimit when getting permission denied error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQJTkUeMSsaLdpyqXhB3CMkD4P1NRPmjWA=iuyLpYbu-Lw@mail.gmail.com>
Date:   Mon, 16 Dec 2019 14:54:50 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Yonghong Song <yhs@...com>
Subject: Re: [PATCH bpf-next v2] libbpf: Print hint about ulimit when getting
 permission denied error

On Mon, Dec 16, 2019 at 10:12 AM Toke Høiland-Jørgensen <toke@...hat.com> wrote:
>
> Probably the single most common error newcomers to XDP are stumped by is
> the 'permission denied' error they get when trying to load their program
> and 'ulimit -l' is set too low. For examples, see [0], [1].
>
> Since the error code is UAPI, we can't change that. Instead, this patch
> adds a few heuristics in libbpf and outputs an additional hint if they are
> met: If an EPERM is returned on map create or program load, and geteuid()
> shows we are root, and the current RLIMIT_MEMLOCK is not infinity, we
> output a hint about raising 'ulimit -l' as an additional log line.
>
> [0] https://marc.info/?l=xdp-newbies&m=157043612505624&w=2
> [1] https://github.com/xdp-project/xdp-tutorial/issues/86
>
> Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>
> Acked-by: Yonghong Song <yhs@...com>
> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
> ---
> v2:
>   - Format current output as KiB/MiB
>   - It's ulimit -l, not ulimit -r

Applied. Thanks