netdev - Re: [PATCH] net: l2tp: remove unneeded MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75d6a169-d977-441a-f9b5-292be0c9a3f1@metux.net>
Date:   Mon, 16 Dec 2019 09:38:20 +0100
From:   "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
To:     David Miller <davem@...emloft.net>, info@...ux.net
Cc:     linux-kernel@...r.kernel.org, jchapman@...alix.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: l2tp: remove unneeded MODULE_VERSION() usage

On 12.12.19 20:03, David Miller wrote:

Hi,

> Is there a plan to remove MODULE_VERSION across the entire kernel tree?

I'm not entirely sure, but for all I know it just doesn't make sense at
all to have it (maybe except for OOT modules) and already was removed in
several places. For example, Greg cleansed it from the input subsys a
few years ago:

	https://lkml.org/lkml/2017/11/22/480

Similar patch for gpio subsys was accepted recently.

This got my attention by some discussion on some patches introducing new
module w/ including such macro call. The consensus from the discussion
was that the MODULE_VERSION() shouldn't be used, so I prepared some
patches to remove it in many places.

If you like to keep it in, give me a clear reject (maybe also a short
list of other areas under your maintainership), so I can skip it out
and don't bother you again :)

Personally, I believe, we shouldn't keep things that don't really serve
any purpose. Does anybody ever actually use it ?

By the way: we've got a similar thing with network devices, they've got
a version field. But it seems not all drivers filling it.

What is that used for ?

--mtx

---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@...ux.net -- +49-151-27565287