netdev - Re: [PATCH] net: gemini: Fix memory leak in gmac_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYZDj+rO0WL3wFtVM0Kosx5LWrKDLkUvmqV4EVXtSeO-w@mail.gmail.com>
Date:   Mon, 16 Dec 2019 11:20:33 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Navid Emamdoost <navid.emamdoost@...il.com>
Cc:     Hans Ulli Kroll <ulli.kroll@...glemail.com>,
        "David S. Miller" <davem@...emloft.net>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        netdev <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        emamd001@....edu
Subject: Re: [PATCH] net: gemini: Fix memory leak in gmac_setup_txqs

On Sun, Dec 15, 2019 at 2:11 AM Navid Emamdoost
<navid.emamdoost@...il.com> wrote:

> In the implementation of gmac_setup_txqs() the allocated desc_ring is
> leaked if TX queue base is not aligned. Release it via
> dma_free_coherent.
>
> Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet")
> Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com>

Looks correct to me,
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij