netdev - Re: [PATCH net-next] r8169: check that Realtek PHY driver module is loaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191216.160042.1123553178502537234.davem@davemloft.net>
Date:   Mon, 16 Dec 2019 16:00:42 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] r8169: check that Realtek PHY driver module
 is loaded

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Fri, 13 Dec 2019 16:53:37 +0100

> Some users complained about problems with r8169 and it turned out that
> the generic PHY driver was used instead instead of the dedicated one.
> In all cases reason was that r8169.ko was in initramfs, but realtek.ko
> not. Manually adding realtek.ko to initramfs fixed the issues.
> Root cause seems to be that tools like dracut and genkernel don't
> consider softdeps. Add a check for loaded Realtek PHY driver module
> and provide the user with a hint if it's not loaded.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied but this really is a failure of the dependency system and tooling.

I don't know if tools like dracut is where this has to happen or
something closer to the kernel module dep system itself, but what's
happening right now obviously does not work.