netdev - [PATCH net-next 0/2] net: sched: unify __gnet_stats_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191217084718.52098-1-dust.li@linux.alibaba.com>
Date:   Tue, 17 Dec 2019 16:47:16 +0800
From:   Dust Li <dust.li@...ux.alibaba.com>
To:     Cong Wang <xiyou.wangcong@...il.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        John Fastabend <john.fastabend@...il.com>,
        Jiri Pirko <jiri@...nulli.us>
Cc:     Tony Lu <tonylu@...ux.alibaba.com>, netdev@...r.kernel.org
Subject: [PATCH net-next 0/2] net: sched: unify __gnet_stats_copy_xxx() for percpu and non-percpu

Currently, __gnet_stats_copy_xxx() will overwrite the return value when
percpu stats are not enabled. But when percpu stats are enabled, it will
add the percpu stats to the result. This inconsistency brings confusion to
its callers.

This patch series unify the behaviour of __gnet_stats_copy_basic() and
__gnet_stats_copy_queue() for percpu and non-percpu stats and fix an
incorrect statistic for mqprio class.

- Patch 1 unified __gnet_stats_copy_xxx() for both percpu and non-percpu
- Patch 2 depending on Patch 1, fixes the problem that 'tc class show'
  for mqprio class is always 0.

Dust Li (2):
  net: sched: keep __gnet_stats_copy_xxx() same semantics for percpu
    stats
  net: sched: fix wrong class stats dumping in sch_mqprio

 net/core/gen_stats.c   |  2 ++
 net/sched/sch_mq.c     | 35 ++++++++++++-------------
 net/sched/sch_mqprio.c | 59 +++++++++++++++++++++++-------------------
 3 files changed, 51 insertions(+), 45 deletions(-)

-- 
2.19.1.3.ge56e4f7