netdev - Re: [PATCH] net: dsa: make unexported dsa_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191217113009.GC17965@lunn.ch>
Date:   Tue, 17 Dec 2019 12:30:09 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     "Ben Dooks (Codethink)" <ben.dooks@...ethink.co.uk>
Cc:     Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: dsa: make unexported dsa_link_touch() static

On Tue, Dec 17, 2019 at 11:20:38AM +0000, Ben Dooks (Codethink) wrote:
> dsa_link_touch() is not exported, or defined outside of the
> file it is in so make it static to avoid the following warning:
> 
> net/dsa/dsa2.c:127:17: warning: symbol 'dsa_link_touch' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@...ethink.co.uk>

Fixes: c5f51765a1f6 ("net: dsa: list DSA links in the fabric")
Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew