netdev - Re: [PATCH v2 04/23] staging: qlge: Fix WARNING: Missing a blank line after declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191217123725.GA3161766@kroah.com>
Date:   Tue, 17 Dec 2019 13:37:25 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Scott Schafer <schaferjscott@...il.com>
Cc:     devel@...verdev.osuosl.org, GR-Linux-NIC-Dev@...vell.com,
        Manish Chopra <manishc@...vell.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 04/23] staging: qlge: Fix WARNING: Missing a blank
 line after declarations

On Wed, Dec 11, 2019 at 12:12:33PM -0600, Scott Schafer wrote:
> Fix WARNING: Missing a blank line after declarations in the following
> files:
> qlge.h
> qlge_dbg.c
> qlge_main.c
> qlge_mpi.c
> 
> Signed-off-by: Scott Schafer <schaferjscott@...il.com>
> ---
>  drivers/staging/qlge/qlge.h      |  2 +-
>  drivers/staging/qlge/qlge_dbg.c  | 10 +++++-----
>  drivers/staging/qlge/qlge_main.c | 26 +++++++++++++-------------
>  drivers/staging/qlge/qlge_mpi.c  | 12 ++++++------
>  4 files changed, 25 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h
> index 89502a8300f6..d45c53a053c2 100644
> --- a/drivers/staging/qlge/qlge.h
> +++ b/drivers/staging/qlge/qlge.h
> @@ -2227,7 +2227,7 @@ static inline void ql_write_db_reg_relaxed(u32 val, void __iomem *addr)
>  static inline u32 ql_read_sh_reg(__le32  *addr)
>  {
>  	u32 reg;
> -	
> +

The description of this patch is NOT what this patch is doing.  It's
fixing up the mess you added in the previous patch :(

thanks,

greg k-h