netdev - Re: [PATCH net-next 07/11] net: phy: marvell: use positive logic for link state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191217154619.GO17965@lunn.ch>
Date:   Tue, 17 Dec 2019 16:46:19 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 07/11] net: phy: marvell: use positive logic for
 link state

On Tue, Dec 17, 2019 at 01:39:31PM +0000, Russell King wrote:
> Rather than using negative logic:
> 
> 	if (there is no link)
> 		set link = 0
> 	else
> 		set link = 1
> 
> use the more natural positive logic:
> 
> 	if (there is link)
> 		set link = 1
> 	else
> 		set link = 0
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew