netdev - Re: [PATCH iproute2-next v2 2/2] iplink: bond: print 3ad actor/partner oper states as strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74e45193-2882-cc47-e53b-1373e6a26205@gmail.com>
Date:   Tue, 17 Dec 2019 09:36:42 -0700
From:   David Ahern <dsahern@...il.com>
To:     Andy Roulin <aroulin@...ulusnetworks.com>, netdev@...r.kernel.org
Cc:     dsahern@...il.com, nikolay@...ulusnetworks.com,
        roopa@...ulusnetworks.com, j.vosburgh@...il.com, vfalico@...il.com,
        andy@...yhouse.net, stephen@...workplumber.org
Subject: Re: [PATCH iproute2-next v2 2/2] iplink: bond: print 3ad
 actor/partner oper states as strings

On 12/11/19 3:33 PM, Andy Roulin wrote:
> The 802.3ad actor/partner operating states are only printed as
> numbers, e.g,
> 
> ad_actor_oper_port_state 15
> 
> Add an additional output in ip link show that prints a string describing
> the individual 3ad bit meanings in the following way:
> 
> ad_actor_oper_port_state_str <active,short_timeout,aggregating,in_sync>
> 
> JSON output is also supported, the field becomes a json array:
> 
> "ad_actor_oper_port_state_str":
> 	["active","short_timeout","aggregating","in_sync"]
> 
> Signed-off-by: Andy Roulin <aroulin@...ulusnetworks.com>
> Acked-by: Roopa Prabhu <roopa@...ulusnetworks.com>
> ---
>  ip/iplink_bond_slave.c | 36 ++++++++++++++++++++++++++++++++----
>  1 file changed, 32 insertions(+), 4 deletions(-)
> 

Andy: Update the uapi file per the comments on that thread and resubmit
this patch with the updated names.