netdev - Re: [PATCH bpf-next 3/3] bpftool: add gen subcommand manpage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a722caf8-a4af-4476-d560-396dd30dfb0a@fb.com>
Date:   Tue, 17 Dec 2019 21:27:46 +0000
From:   Yonghong Song <yhs@...com>
To:     Andrii Nakryiko <andriin@...com>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        "daniel@...earbox.net" <daniel@...earbox.net>
CC:     "andrii.nakryiko@...il.com" <andrii.nakryiko@...il.com>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH bpf-next 3/3] bpftool: add gen subcommand manpage



On 12/16/19 9:36 PM, Andrii Nakryiko wrote:
> Add bpftool-gen.rst describing skeleton on the high level. Also include
> a small, but complete, example BPF app (BPF side, userspace side, generated
> skeleton) in example section to demonstrate skeleton API and its usage.
> 
> Signed-off-by: Andrii Nakryiko <andriin@...com>

When applying the patch locally (git apply <>), I see below:
-bash-4.4$ git apply ~/p3.txt
/home/yhs/p3.txt:183: trailing whitespace.

/home/yhs/p3.txt:187: trailing whitespace.

/home/yhs/p3.txt:189: space before tab in indent.
         __uint(type, BPF_MAP_TYPE_HASH);
/home/yhs/p3.txt:190: space before tab in indent.
         __uint(max_entries, 128);
/home/yhs/p3.txt:191: space before tab in indent.
         __type(key, int);
warning: squelched 77 whitespace errors
warning: 82 lines add whitespace errors.
-bash-4.4$

space before tab might be fine since it is an code in the example file.
But tailing whitespaces probably should be fixed.

With the above in mind,

Acked-by: Yonghong Song <yhs@...com>