netdev - Re: [PATCH net v2] dpaa2-ptp: fix double free of the ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191217.141110.248388410704029559.davem@davemloft.net>
Date:   Tue, 17 Dec 2019 14:11:10 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ioana.ciornei@....com
Cc:     netdev@...r.kernel.org, yangbo.lu@....com
Subject: Re: [PATCH net v2] dpaa2-ptp: fix double free of the ptp_qoriq IRQ

From: Ioana Ciornei <ioana.ciornei@....com>
Date: Mon, 16 Dec 2019 17:32:30 +0200

> Upon reusing the ptp_qoriq driver, the ptp_qoriq_free() function was
> used on the remove path to free any allocated resources.
> The ptp_qoriq IRQ is among these resources that are freed in
> ptp_qoriq_free() even though it is also a managed one (allocated using
> devm_request_threaded_irq).
> 
> Drop the resource managed version of requesting the IRQ in order to not
> trigger a double free of the interrupt as below:
 ...
> Fixes: d346c9e86d86 ("dpaa2-ptp: reuse ptp_qoriq driver")
> Cc: Yangbo Lu <yangbo.lu@....com>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>

Applied and queued up for v5.3 -stable.

Thanks.