netdev - Re: [PATCH net v2] net: dsa: ocelot: add NET_VENDOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 16 Dec 2019 19:24:54 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     arnd@...db.de, maowenan@...wei.com, andrew@...n.ch,
        f.fainelli@...il.com, vivien.didelot@...il.com,
        claudiu.manoil@....com, alexandru.marginean@....com,
        xiaoliang.yang_1@....com, yangbo.lu@....com,
        netdev@...r.kernel.org, alexandre.belloni@...tlin.com,
        UNGLinuxDriver@...rochip.com, vladimir.oltean@....com
Subject: Re: [PATCH net v2] net: dsa: ocelot: add NET_VENDOR_MICROSEMI
 dependency

From: Vladimir Oltean <olteanv@...il.com>
Date: Mon, 16 Dec 2019 00:12:14 +0200

> From: Arnd Bergmann <arnd@...db.de>
> 
> Selecting MSCC_OCELOT_SWITCH is not possible when NET_VENDOR_MICROSEMI
> is disabled:
> 
> WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH
>   Depends on [n]: NETDEVICES [=y] && ETHERNET [=n] && NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y]
>   Selected by [m]:
>   - NET_DSA_MSCC_FELIX [=m] && NETDEVICES [=y] && HAVE_NET_DSA [=y] && NET_DSA [=y] && PCI [=y]
> 
> Add a Kconfig dependency on NET_VENDOR_MICROSEMI, which also implies
> CONFIG_NETDEVICES.
> 
> Depending on a vendor config violates menuconfig locality for the DSA
> driver, but is the smallest compromise since all other solutions are
> much more complicated (see [0]).
> 
> https://www.spinics.net/lists/netdev/msg618808.html
> 
> Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Mao Wenan <maowenan@...wei.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Applied.