netdev - Re: [PATCH iproute2 0/3] Devlink health reporter's issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191216205351.1afb8c75@hermes.lan>
Date:   Mon, 16 Dec 2019 20:53:51 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Tariq Toukan <tariqt@...lanox.com>
Cc:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org,
        ayal@...lanox.com, moshe@...lanox.com, jiri@...lanox.com
Subject: Re: [PATCH iproute2 0/3] Devlink health reporter's issues

On Wed, 11 Dec 2019 17:45:33 +0200
Tariq Toukan <tariqt@...lanox.com> wrote:

> Hi,
> 
> This patchset by Aya fixes two issues: wrong time-stamp on a dump in
> devlink health reporter and messy display of non JSON output in devlink
> health diagnostics and dump.
> 
> 1) Wrong time-stamp on a dump in devlink health reporter: 
> This bug fix consist of 2 patches. First patch refactors the current
> implementation of helper function which displays the reporter's dump
> time-stamp and add the actual print to the function's body.
> The second patch introduces a new attribute which is the time-stamp in
> current time in nsec instead of jiffies. When the new attribute is
> present try and translate the time-stamp according to 'current time'.
> 
> 2) Messy display of non-JSON output in devlink health diagnostics and dump:
> This patch mainly deals with dynamic object and array opening. The
> label is stored and only when the proceeding value arrives the name is
> printed with regards to the context. 
> 
> Series generated against the shared master/net-next head:
> 24bee3bf9752 tipc: add new commands to set TIPC AEAD key
> 
> Regards,
> Tariq
> 
> Aya Levin (3):
>   devlink: Print health reporter's dump time-stamp in a helper function
>   devlink: Add a new time-stamp format for health reporter's dump
>   devlink: Fix fmsg nesting in non JSON output
> 
>  devlink/devlink.c | 153 +++++++++++++++++++++++++++++++++++-----------
>  1 file changed, 119 insertions(+), 34 deletions(-)
> 

Applied, devlink really needs to get converted to same json
library as rest of iproute2.