netdev - RE: linux-next: manual merge of the net-next tree with the net tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56c41d0552944b1fb62b466aea6c79ee@EX13D11EUB003.ant.amazon.com>
Date:   Tue, 17 Dec 2019 06:55:05 +0000
From:   "Jubran, Samih" <sameehj@...zon.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        David Miller <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>
CC:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        "Belgazal, Netanel" <netanel@...zon.com>
Subject: RE: linux-next: manual merge of the net-next tree with the net tree



> -----Original Message-----
> From: Stephen Rothwell <sfr@...b.auug.org.au>
> Sent: Monday, December 16, 2019 1:05 AM
> To: David Miller <davem@...emloft.net>; Networking
> <netdev@...r.kernel.org>
> Cc: Linux Next Mailing List <linux-next@...r.kernel.org>; Linux Kernel
> Mailing List <linux-kernel@...r.kernel.org>; Belgazal, Netanel
> <netanel@...zon.com>; Jubran, Samih <sameehj@...zon.com>
> Subject: linux-next: manual merge of the net-next tree with the net tree
> 
> Hi all,
> 
> Today's linux-next merge of the net-next tree got a conflict in:
> 
>   drivers/net/ethernet/amazon/ena/ena_netdev.c
> 
> between commit:
> 
>   24dee0c7478d ("net: ena: fix napi handler misbehavior when the napi
> budget is zero")
> 
> from the net tree and commit:
> 
>   548c4940b9f1 ("net: ena: Implement XDP_TX action")
> 
> from the net-next tree.
> 
> I fixed it up (see below) and can carry the fix as necessary. This is now fixed
> as far as linux-next is concerned, but any non trivial conflicts should be
> mentioned to your upstream maintainer when your tree is submitted for
> merging.  You may also want to consider cooperating with the maintainer of
> the conflicting tree to minimise any particularly complex conflicts.
> 
> --
> Cheers,
> Stephen Rothwell
> 
> diff --cc drivers/net/ethernet/amazon/ena/ena_netdev.c
> index 948583fdcc28,26954fde4766..000000000000
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@@ -1237,9 -1861,8 +1861,8 @@@ static int ena_io_poll(struct napi_stru
>   {
>   	struct ena_napi *ena_napi = container_of(napi, struct ena_napi,
> napi);
>   	struct ena_ring *tx_ring, *rx_ring;
> -
>  -	u32 tx_work_done;
>  -	u32 rx_work_done;
>  +	int tx_work_done;
>  +	int rx_work_done = 0;
>   	int tx_budget;
>   	int napi_comp_call = 0;
>   	int ret;

Thanks, looks good to me. Sorry for the inconvenience.