netdev - Re: [PATCH v5 2/2] bluetooth: hci_bcm: enable IRQ capability from devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Dec 2019 08:43:07 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Kevin Hilman <khilman@...libre.com>
Cc:     Guillaume La Roque <glaroque@...libre.com>,
        Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, devicetree@...r.kernel.org,
        netdev@...r.kernel.org, nsaenzjulienne@...e.de,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/2] bluetooth: hci_bcm: enable IRQ capability from
 devicetree

Hi Guillaume,

>> Actually IRQ can be found from GPIO but all platforms don't support
>> gpiod_to_irq, it's the case on amlogic chip.
>> so to have possibility to use interrupt mode we need to add interrupts
>> property in devicetree and support it in driver.
> 
> I would reword this slightly (leaving out the amlogic specifics):
> 
> """
> Add support for getting IRQ directly from DT instead of relying on
> converting a GPIO to IRQ. This is needed for platforms with GPIO
> controllers that that do not support gpiod_to_irq().
> """
> 
> Other than that, this looks good to me and now it's clear that it only
> affects the DT path.
> 
> Reviewed-by: Kevin Hilman <khilman@...libre.com>

I reverted the broken patch and now I am waiting for v6 with proper reviewed-by or acked-by tags.

Regards

Marcel