netdev - Re: [PATCH stable v4.4 1/2] net: stmmac: use correct DMA buffer size in the RX descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Dec 2019 08:51:32 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Aviraj CJ <acj@...co.com>
Cc:     peppe.cavallaro@...com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        xe-linux-external@...co.com
Subject: Re: [PATCH stable v4.4 1/2] net: stmmac: use correct DMA buffer size
 in the RX descriptor

On Mon, Dec 16, 2019 at 09:52:27PM -0800, Aviraj CJ wrote:
> upstream 583e6361414903c5206258a30e5bd88cb03c0254 commit
> 
> We always program the maximum DMA buffer size into the receive descriptor,
> although the allocated size may be less. E.g. with the default MTU size
> we allocate only 1536 bytes. If somebody sends us a bigger frame, then
> memory may get corrupted.
> 
> Program DMA using exact buffer sizes.
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@...ia.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> [acj: backport to v4.4 -stable :
> - Modified patch since v4.4 driver has no support for Big endian
> - Skipped the section modifying non-existent functions in dwmac4_descs.c and
> dwxgmac2_descs.c ]
> Signed-off-by: Aviraj CJ <acj@...co.com>

I can't take stable patches for an older tree and have it "skip" newer
stable trees.  To be specific, this patch is already in the 4.19.41
release, but if I were to take it into the 4.4.y tree, then anyone
upgrading to 4.9.y or 4.14.y afterward would run into the same issue.

So can you also send backports to 4.9.y and 4.14.y so that I can take
this fix into all trees?

Same for patch 2/2.

thanks,

greg k-h