netdev - RE: [PATCH net-next 1/3] net: emaclite: Fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CH2PR02MB700048BB28C0D3625B1B7AC3C7530@CH2PR02MB7000.namprd02.prod.outlook.com>
Date:   Wed, 18 Dec 2019 13:34:50 +0000
From:   Radhey Shyam Pandey <radheys@...inx.com>
To:     David Miller <davem@...emloft.net>
CC:     Michal Simek <michals@...inx.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        git <git@...inx.com>
Subject: RE: [PATCH net-next 1/3] net: emaclite: Fix coding style

> -----Original Message-----
> From: David Miller <davem@...emloft.net>
> Sent: Wednesday, December 18, 2019 3:27 AM
> To: Radhey Shyam Pandey <radheys@...inx.com>
> Cc: Michal Simek <michals@...inx.com>; netdev@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; git
> <git@...inx.com>
> Subject: Re: [PATCH net-next 1/3] net: emaclite: Fix coding style
> 
> From: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>
> Date: Mon, 16 Dec 2019 17:38:08 +0530
> 
> > -	spinlock_t reset_lock;
> > +	spinlock_t reset_lock; /* lock used for synchronization */
> 
> If you're just going to put the comment there to shut up the warnings,
> I'm not applying your patches.
> 
> You have to write a thoughtful comment which explains what this lock
> actually protects.
Thanks for the review. Sure, will fix reset_lock comment
and also its kernel-doc description in v2.