netdev - Re: [PATCH] net-sysfs: Call dev_hold always in rx_queue_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201912180136.xBI1alSc017861@www262.sakura.ne.jp>
Date:   Wed, 18 Dec 2019 10:36:47 +0900
From:   Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
To:     David Miller <davem@...emloft.net>
Cc:     jouni.hogander@...kie.com, netdev@...r.kernel.org,
        penguin-kernel@...ove.SAKURA.ne.jp, lukas.bulwahn@...il.com
Subject: Re: [PATCH] net-sysfs: Call dev_hold always in rx_queue_add_kobject

David Miller wrote:
> From: jouni.hogander@...kie.com
> Date: Tue, 17 Dec 2019 10:44:29 +0200
> 
> > From: Jouni Hogander <jouni.hogander@...kie.com>
> > 
> > Dev_hold has to be called always in rx_queue_add_kobject.
> > Otherwise usage count drops below 0 in case of failure in
> > kobject_init_and_add.
> > 
> > Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject")
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Cc: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> > Cc: David Miller <davem@...emloft.net>
> > Cc: Lukas Bulwahn <lukas.bulwahn@...il.com>
> > Signed-off-by: Jouni Hogander <jouni.hogander@...kie.com>
> 
> Why are you posting this again, the change is already in my tree?
> 

Not posting again. Previous patch was for "netdev_queue_add_kobject" and
this patch is for "rx_queue_add_kobject". Also, Reported-by: in this patch
is wrong. Please apply an updated patch shown below.

  Date: Tue, 17 Dec 2019 13:46:34 +0200
  Message-Id: <20191217114634.9428-1-jouni.hogander@...kie.com>