netdev - Re: [PATCH v2] llc2: Remove the condition operator in llc_stat_ev_rx_null_dsap_xid_c and llc_stat_ev_rx_null_dsap_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191218150737.GA5800@rhel76>
Date:   Wed, 18 Dec 2019 23:07:37 +0800
From:   "Chan Shu Tak, ALex" <alexchan@...k.com.hk>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] llc2: Remove the condition operator in
 llc_stat_ev_rx_null_dsap_xid_c and llc_stat_ev_rx_null_dsap_test_c.

On Tue, Dec 17, 2019 at 10:18:46PM -0800, David Miller wrote:
> From: "Chan Shu Tak, Alex" <alexchan@...k.com.hk>
> Date: Tue, 17 Dec 2019 12:00:36 +0800
> 
> > @@ -32,7 +32,7 @@ static int llc_stat_ev_rx_null_dsap_xid_c(struct sk_buff *skb)
> >  	return LLC_PDU_IS_CMD(pdu) &&			/* command PDU */
> >  	       LLC_PDU_TYPE_IS_U(pdu) &&		/* U type PDU */
> >  	       LLC_U_PDU_CMD(pdu) == LLC_1_PDU_CMD_XID &&
> > -	       !pdu->dsap ? 1 : 0;			/* NULL DSAP value */
> > +	       !pdu->dsap;				/* NULL DSAP value */
> 
> This isn't a v2 of your patch, it's a patch against v1 of your patch.
> 
> Please do this properly, thank you.

Thanks for your comments and patience and sorry for the troubles that I caused.

I will revise my patch and try again.

In this case, should I start anew or continue on this thread? 

Thanks again for your time.