netdev - Re: [RFC net-next 03/14] libbpf: API for tx path XDP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191218182011.oatv5zermnkdspie@ast-mbp.dhcp.thefacebook.com>
Date:   Wed, 18 Dec 2019 10:20:12 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Prashant Bhole <prashantbhole.linux@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        "Michael S . Tsirkin" <mst@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        Jason Wang <jasowang@...hat.com>,
        David Ahern <dsahern@...il.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        John Fastabend <john.fastabend@...il.com>,
        Toshiaki Makita <toshiaki.makita1@...il.com>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>, netdev@...r.kernel.org,
        David Ahern <dahern@...italocean.com>
Subject: Re: [RFC net-next 03/14] libbpf: API for tx path XDP support

On Wed, Dec 18, 2019 at 05:10:39PM +0900, Prashant Bhole wrote:
> Adds new APIs for tx path XDP:
>  - bpf_set_link_xdp_tx_fd
>  - bpf_get_link_xdp_tx_id
>  - bpf_get_link_xdp_tx_info
> 
> Co-developed-by: David Ahern <dahern@...italocean.com>
> Signed-off-by: David Ahern <dahern@...italocean.com>
> Signed-off-by: Prashant Bhole <prashantbhole.linux@...il.com>
> ---
>  tools/lib/bpf/libbpf.h   |  4 +++
>  tools/lib/bpf/libbpf.map |  3 ++
>  tools/lib/bpf/netlink.c  | 77 +++++++++++++++++++++++++++++++++++-----
>  3 files changed, 75 insertions(+), 9 deletions(-)
> 
> diff --git a/tools/lib/bpf/libbpf.h b/tools/lib/bpf/libbpf.h
> index 0dbf4bfba0c4..741e5fee61f6 100644
> --- a/tools/lib/bpf/libbpf.h
> +++ b/tools/lib/bpf/libbpf.h
> @@ -447,6 +447,10 @@ LIBBPF_API int bpf_set_link_xdp_fd(int ifindex, int fd, __u32 flags);
>  LIBBPF_API int bpf_get_link_xdp_id(int ifindex, __u32 *prog_id, __u32 flags);
>  LIBBPF_API int bpf_get_link_xdp_info(int ifindex, struct xdp_link_info *info,
>  				     size_t info_size, __u32 flags);
> +LIBBPF_API int bpf_set_link_xdp_tx_fd(int ifindex, int fd, __u32 flags);
> +LIBBPF_API int bpf_get_link_xdp_tx_id(int ifindex, __u32 *prog_id, __u32 flags);
> +LIBBPF_API int bpf_get_link_xdp_tx_info(int ifindex, struct xdp_link_info *info,
> +				     size_t info_size, __u32 flags);

please use _opts() style of api extensions.