netdev - Re: [PATCH v3 bpf-next 0/3] Skeleton improvements and documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzZU62cEfkA0JBAC0sNc8bKsD9vHh=3AnNXoT9fMDsoR=g@mail.gmail.com>
Date:   Wed, 18 Dec 2019 10:31:43 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v3 bpf-next 0/3] Skeleton improvements and documentation

On Tue, Dec 17, 2019 at 10:23 PM Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
> On Tue, Dec 17, 2019 at 09:25:49PM -0800, Andrii Nakryiko wrote:
> > Simplify skeleton usage by embedding source BPF object file inside skeleton
> > itself. This allows to keep skeleton and object file in sync at all times with
> > no chance of confusion.
> >
> > Also, add bpftool-gen.rst manpage, explaining concepts and ideas behind
> > skeleton. In examples section it also includes a complete small BPF
> > application utilizing skeleton, as a demonstration of API.
> >
> > Patch #2 also removes BPF_EMBED_OBJ, as there is currently no use of it.
> >
> > v2->v3:
> > - (void) in no-args function (Alexei);
> > - bpftool-gen.rst code block formatting fix (Alexei);
> > - simplified xxx__create_skeleton to fill in obj and return error code;
> >
> > v1->v2:
> > - remove whitespace from empty lines in code blocks (Yonghong).
>
> Applied. Thanks.
>
> This bit:
> +                 layout will be created. Currently supported ones are: .data,
> +                 .bss, .rodata, and .extern structs/data sections. These
> didn't render correctly in the man page for me.
> Not sure whehther it's an issue in my setup or .rst is invalid.
> Please take a look.

Will do, I see the same. Must be some weird dot interaction in
reStructureText syntax, no idea...


> Overall new man page looks great.
>

Thanks!