netdev - Re: [PATCH net-next v3 07/11] tcp: Prevent coalesce/collapse when skb has MPTCP extensions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Dec 2019 14:36:09 -0700
From:   subashab@...eaurora.org
To:     Mat Martineau <mathew.j.martineau@...ux.intel.com>
Cc:     David Miller <davem@...emloft.net>, eric.dumazet@...il.com,
        netdev@...r.kernel.org, mptcp@...ts.01.org,
        netdev-owner@...r.kernel.org
Subject: Re: [PATCH net-next v3 07/11] tcp: Prevent coalesce/collapse when skb
 has MPTCP extensions

> Ok, understood. Not every packet has this MPTCP extension data so
> coalescing was not always turned off, but given the importance of
> avoiding
> 
> this memory waste I'll confirm GRO behavior and work on maintaining
> coalesce/collapse with identical MPTCP extension data.
> 

Hi Mat

Are identical MPTCP extensions a common case?
AFAIK the data sequence number and the subflow sequence number change
per packet even in a single stream scenario.