netdev - Re: [MPTCP] Re: [PATCH net-next v3 07/11] tcp: Prevent coalesce/collapse when skb has MPTCP extensions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191218.151732.2019141834931247672.davem@davemloft.net>
Date:   Wed, 18 Dec 2019 15:17:32 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     eric.dumazet@...il.com, netdev@...r.kernel.org, mptcp@...ts.01.org
Subject: Re: [MPTCP] Re: [PATCH net-next v3 07/11] tcp: Prevent
 coalesce/collapse when skb has MPTCP extensions

From: Paolo Abeni <pabeni@...hat.com>
Date: Wed, 18 Dec 2019 23:15:46 +0100

> Just to clarify, with the code we have currently posted TSO trains of
> MPTCP packets can be aggregated by the GRO engine almost exactly as
> currently happens for plain TCP packets.
> 
> We still have chances to aggregate packets belonging to a MPTCP stream,
> as not all of them carry a DSS option.
> 
> We opted to not coalesce at the TCP level for the moment to avoid
> adding additional hook code inside the coalescing code.
> 
> If you are ok without such hooks in the initial version, we can handle
> MPTCP coalescing, too. The real work will likely land in part 2.
> 
> Would that fit you?

Can't you someone encode the MPTCP metadata so that it will only apply
to a range or something like that?  Would that help?