netdev - Re: [PATCH net-next mlxsw v1 00/10] Add a new Qdisc, ETS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191217.213823.770260276225386300.davem@davemloft.net>
Date:   Tue, 17 Dec 2019 21:38:23 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     petrm@...lanox.com
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        jakub.kicinski@...ronome.com, mrv@...atatu.com,
        idosch@...lanox.com, jiri@...nulli.us
Subject: Re: [PATCH net-next mlxsw v1 00/10] Add a new Qdisc, ETS

From: Petr Machata <petrm@...lanox.com>
Date: Mon, 16 Dec 2019 17:01:36 +0000

> The IEEE standard 802.1Qaz (and 802.1Q-2014) specifies four principal
> transmission selection algorithms: strict priority, credit-based shaper,
> ETS (bandwidth sharing), and vendor-specific. All these have their
> corresponding knobs in DCB. But DCB does not have interfaces to configure
> RED and ECN, unlike Qdiscs.
 ...

I have no problem with this new schedule or how it is coded.

But I really want there to be some documentation blurb in the Kconfig
entry (less verbose) and in a code comment of the scheduler itself
(more verbose) which explains where this is derived from.

People can indeed look at the commit but I think if someone just sees
the new Kconfig or looks at the code they should be able to read
something there that says what this thing is.

The commit log message for patch #4 would be good to use as a basis.

Thank you.