netdev - Re: [PATCH net] net: annotate lockless accesses to sk->sk_pacing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191217.221351.137832734104800157.davem@davemloft.net>
Date:   Tue, 17 Dec 2019 22:13:51 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net] net: annotate lockless accesses to
 sk->sk_pacing_shift

From: Eric Dumazet <edumazet@...gle.com>
Date: Mon, 16 Dec 2019 18:51:03 -0800

> sk->sk_pacing_shift can be read and written without lock
> synchronization. This patch adds annotations to
> document this fact and avoid future syzbot complains.
> 
> This might also avoid unexpected false sharing
> in sk_pacing_shift_update(), as the compiler
> could remove the conditional check and always
> write over sk->sk_pacing_shift :
> 
> if (sk->sk_pacing_shift != val)
> 	sk->sk_pacing_shift = val;
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.