netdev - Re: [PATCH net 1/1] nfp: flower: fix stats id allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191217.224955.497657953140914814.davem@davemloft.net>
Date:   Tue, 17 Dec 2019 22:49:55 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     john.hurley@...ronome.com
Cc:     netdev@...r.kernel.org, simon.horman@...ronome.com,
        jakub.kicinski@...ronome.com, oss-drivers@...ronome.com
Subject: Re: [PATCH net 1/1] nfp: flower: fix stats id allocation

From: John Hurley <john.hurley@...ronome.com>
Date: Tue, 17 Dec 2019 11:28:56 +0000

> As flower rules are added, they are given a stats ID based on the number
> of rules that can be supported in firmware. Only after the initial
> allocation of all available IDs does the driver begin to reuse those that
> have been released.
> 
> The initial allocation of IDs was modified to account for multiple memory
> units on the offloaded device. However, this introduced a bug whereby the
> counter that controls the IDs could be decremented before the ID was
> assigned (where it is further decremented). This means that the stats ID
> could be assigned as -1/0xfffffff which is out of range.
> 
> Fix this by only decrementing the main counter after the current ID has
> been assigned.
> 
> Fixes: 467322e2627f ("nfp: flower: support multiple memory units for filter offloads")
> Signed-off-by: John Hurley <john.hurley@...ronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied and queued up for -stable, thanks.