netdev - Re: [PATCH net 1/1] qede: Disable hardware gro when xdp prog is installed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLi=SPzHRXXMYXNecRjYNaKVZ5uOz1DAhZXXLLF4A+Wh2mA@mail.gmail.com>
Date:   Thu, 19 Dec 2019 14:29:26 -0800
From:   Michael Chan <michael.chan@...adcom.com>
To:     Manish Chopra <manishc@...vell.com>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>, aelior@...vell.com,
        skalluru@...vell.com
Subject: Re: [PATCH net 1/1] qede: Disable hardware gro when xdp prog is installed

On Thu, Dec 19, 2019 at 10:35 AM Manish Chopra <manishc@...vell.com> wrote:
>
> commit 18c602dee472 ("qede: Use NETIF_F_GRO_HW.") introduced
> a regression in driver that when xdp program is installed on
> qede device, device's aggregation feature (hardware GRO) is not
> getting disabled, which is unexpected with xdp.
>
> Fixes: 18c602dee472 ("qede: Use NETIF_F_GRO_HW.")
> Signed-off-by: Manish Chopra <manishc@...vell.com>
> Signed-off-by: Ariel Elior <aelior@...vell.com>

Reviewed-by: Michael Chan <michael.chan@...adcom.com>