lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Dec 2019 09:26:02 +0100 From: Steffen Klassert <steffen.klassert@...unet.com> To: Willem de Bruijn <willemdebruijn.kernel@...il.com> CC: David Miller <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>, Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, Network Development <netdev@...r.kernel.org> Subject: Re: [PATCH net-next 4/4] udp: Support UDP fraglist GRO/GSO. On Wed, Dec 18, 2019 at 11:03:09AM -0500, Willem de Bruijn wrote: > On Wed, Dec 18, 2019 at 8:35 AM Steffen Klassert > <steffen.klassert@...unet.com> wrote: > > > @@ -544,6 +585,18 @@ INDIRECT_CALLABLE_SCOPE int udp4_gro_complete(struct sk_buff *skb, int nhoff) > > const struct iphdr *iph = ip_hdr(skb); > > struct udphdr *uh = (struct udphdr *)(skb->data + nhoff); > > > > + if (NAPI_GRO_CB(skb)->is_flist) { > > + uh->len = htons(skb->len - nhoff); > > + > > + skb_shinfo(skb)->gso_type |= (SKB_GSO_FRAGLIST|SKB_GSO_UDP_L4); > > + skb_shinfo(skb)->gso_segs = NAPI_GRO_CB(skb)->count; > > + > > + skb->ip_summed = CHECKSUM_UNNECESSARY; > > + skb->csum_level = ~0; > > why is this needed for ipv4 only? It is needed for IPv6 too, I've just forgot to add it there. Thanks for the review!
Powered by blists - more mailing lists