lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Dec 2019 11:04:38 +0200 From: Baruch Siach <baruch@...s.co.il> To: Marek BehĂșn <marek.behun@....cz> Cc: Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, netdev@...r.kernel.org, Denis Odintsov <d.odintsov@...viangames.com>, Hubert Feurstein <h.feurstein@...il.com> Subject: Re: [BUG] mv88e6xxx: tx regression in v5.3 Hi Marek, On Wed, Dec 18, 2019 at 03:30:35PM +0100, Marek BehĂșn wrote: > On Sun, 15 Dec 2019 12:13:25 +0200 > Baruch Siach <baruch@...s.co.il> wrote: > > > Thanks. That is enough to fix the phylink issue triggered by commit > > 7fb5a711545 ("net: dsa: mv88e6xxx: drop adjust_link to enabled > > phylink"). > > > > The Clearfog GT-8K DT has also this on the cpu side: > > > > &cp1_eth2 { > > status = "okay"; > > phy-mode = "2500base-x"; > > phys = <&cp1_comphy5 2>; > > fixed-link { > > speed = <2500>; > > full-duplex; > > }; > > }; > > > > Should I drop fixed-link here as well? > > I would think yes. phy-mode = 2500base-x should already force 2500mbps, > the fixed-link should be irrelevant. Whether this is truly the case I > do not know, but on Turris Mox I do not use fixed-link with these. It doesn't work here without fixed-link. The link state remains down. baruch > > The call to mv88e6341_port_set_cmode() introduced in commit > > 7a3007d22e8 ("net: dsa: mv88e6xxx: fully support SERDES on Topaz > > family") still breaks port 5 (cpu) configuration. When called, its > > mode parameter is set to PHY_INTERFACE_MODE_2500BASEX (19). > > > > Any idea? > > I shall look into this. On Turris Mox this works, so I will have to do > some experiments. -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@...s.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
Powered by blists - more mailing lists