netdev - Re: [PATCH net-next v5 09/11] tcp: Check for filled TCP option space before SACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <034d02ef-e760-3cfa-a6a4-4a1943e73783@gmail.com>
Date:   Fri, 20 Dec 2019 07:27:54 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        netdev@...r.kernel.org, mptcp@...ts.01.org
Cc:     Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v5 09/11] tcp: Check for filled TCP option space
 before SACK



On 12/19/19 2:34 PM, Mat Martineau wrote:
> Update the SACK check to work with zero option space available, a case
> that's possible with MPTCP but not MD5+TS. Maintained only one
> conditional branch for insufficient SACK space.
> 
> v1 -> v2:
> - Moves the check inside the SACK branch by taking recent SACK fix:
> 
>     9424e2e7ad93 (tcp: md5: fix potential overestimation of TCP option space)
> 
>   in to account, but modifies it to work in MPTCP scenarios beyond the
>   MD5+TS corner case.
> 
> Co-developed-by: Paolo Abeni <pabeni@...hat.com>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> Signed-off-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>