netdev - Re: [PATCH net-next v5 06/11] mptcp: Add MPTCP to skb extensions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb8a3c9d-4234-1f3a-27f9-3c65fd4496b5@gmail.com>
Date:   Fri, 20 Dec 2019 07:33:37 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        netdev@...r.kernel.org, mptcp@...ts.01.org
Cc:     Matthieu Baerts <matthieu.baerts@...sares.net>
Subject: Re: [PATCH net-next v5 06/11] mptcp: Add MPTCP to skb extensions



On 12/19/19 2:34 PM, Mat Martineau wrote:
> Add enum value for MPTCP and update config dependencies
> 
> Co-developed-by: Matthieu Baerts <matthieu.baerts@...sares.net>
> Signed-off-by: Matthieu Baerts <matthieu.baerts@...sares.net>
> Signed-off-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

...

> +/* MPTCP sk_buff extension data */
> +struct mptcp_ext {
> +	u64		data_ack;
> +	u64		data_seq;
> +	u32		subflow_seq;
> +	u16		data_len;
> +	u8		use_map:1,
> +			dsn64:1,
> +			data_fin:1,
> +			use_ack:1,
> +			ack64:1,
> +			__unused:2;
	__unused:3; 

Also worth noting there is one byte hole in this structure.

> +};
> +