netdev - Re: [PATCH bpf] samples/bpf: xdp_redirect_cpu fix missing tracepoint attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzbnL43Dka+qsTmUYvEnqSHOS72J+eE1qOnHCQdMAkR4Zg@mail.gmail.com>
Date:   Fri, 20 Dec 2019 09:44:42 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Maciek Fijałkowski 
        <maciejromanfijalkowski@...il.com>,
        Daniel Borkmann <borkmann@...earbox.net>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Björn Töpel <bjorn.topel@...el.com>
Subject: Re: [PATCH bpf] samples/bpf: xdp_redirect_cpu fix missing tracepoint attach

On Fri, Dec 20, 2019 at 8:19 AM Jesper Dangaard Brouer
<brouer@...hat.com> wrote:
>
> When sample xdp_redirect_cpu was converted to use libbpf, the
> tracepoints used by this sample were not getting attached automatically
> like with bpf_load.c. The BPF-maps was still getting loaded, thus
> nobody notice that the tracepoints were not updating these maps.
>
> This fix doesn't use the new skeleton code, as this bug was introduced
> in v5.1 and stable might want to backport this. E.g. Red Hat QA uses
> this sample as part of their testing.
>
> Fixes: bbaf6029c49c ("samples/bpf: Convert XDP samples to libbpf usage")
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
> ---

Acked-by: Andrii Nakryiko <andriin@...com>

>  samples/bpf/xdp_redirect_cpu_user.c |   59 +++++++++++++++++++++++++++++++++--
>  1 file changed, 55 insertions(+), 4 deletions(-)
>

[...]