netdev - Re: [patch net-next 0/4] net: allow per-net notifier to follow netdev into namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72587b16-d459-aa6e-b813-cf14b4118b0c@gmail.com>
Date:   Fri, 20 Dec 2019 11:30:22 -0700
From:   David Ahern <dsahern@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, jakub.kicinski@...ronome.com,
        saeedm@...lanox.com, leon@...nel.org, tariqt@...lanox.com,
        ayal@...lanox.com, vladbu@...lanox.com, michaelgur@...lanox.com,
        moshe@...lanox.com, mlxsw@...lanox.com
Subject: Re: [patch net-next 0/4] net: allow per-net notifier to follow netdev
 into namespace

On 12/20/19 5:35 AM, Jiri Pirko wrote:
> However if netdev can change namespace, per-net notifier cannot be used.
> Introduce dev_net variant that is basically per-net notifier with an
> extension that re-registers the per-net notifier upon netdev namespace
> change. Basically the per-net notifier follows the netdev into
> namespace.

This is getting convoluted.

If the driver wants notifications in a new namespace, then it should
register for notifiers in the new namespace. The info for
NETDEV_UNREGISTER event could indicate the device is getting moved to a
new namespace and the driver register for notifications in the new
namespace. If the drivers are trying to be efficient wrt to
notifications then it will need to unregister when all netdevices leave
a namespace which it means it has work to do on namespace changes.