netdev - Re: [PATCH net v2] cxgb4: fix refcount init for TC-MQPRIO offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191220.141411.1525508525740394923.davem@davemloft.net>
Date:   Fri, 20 Dec 2019 14:14:11 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     rahul.lakkireddy@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com, vishal@...lsio.com,
        dt@...lsio.com
Subject: Re: [PATCH net v2] cxgb4: fix refcount init for TC-MQPRIO offload

From: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>
Date: Wed, 18 Dec 2019 09:19:29 +0530

> Properly initialize refcount to 1 when hardware queue arrays for
> TC-MQPRIO offload have been freshly allocated. Otherwise, following
> warning is observed. Also fix up error path to only free hardware
> queue arrays when refcount reaches 0.
 ...
> v2:
> - Move the refcount_set() closer to where the hardware queue arrays
>   are being allocated.
> - Fix up error path to only free hardware queue arrays when refcount
>   reaches 0.
> 
> Fixes: 2d0cb84dd973 ("cxgb4: add ETHOFLD hardware queue support")
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>

Applied, thank you.