netdev - Re: [PATCH V7 net-next 01/11] net: phy: Introduce helper functions for time stamping support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2c17e94-bf36-0816-260b-07fededd0e42@gmail.com>
Date:   Fri, 20 Dec 2019 14:24:48 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org
Cc:     David Miller <davem@...emloft.net>, devicetree@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Mark Rutland <mark.rutland@....com>,
        Miroslav Lichvar <mlichvar@...hat.com>,
        Murali Karicheri <m-karicheri2@...com>,
        Rob Herring <robh+dt@...nel.org>,
        Willem de Bruijn <willemb@...gle.com>,
        Wingman Kwok <w-kwok2@...com>
Subject: Re: [PATCH V7 net-next 01/11] net: phy: Introduce helper functions
 for time stamping support.

On 12/20/19 10:15 AM, Richard Cochran wrote:
> Some parts of the networking stack and at least one driver test fields
> within the 'struct phy_device' in order to query time stamping
> capabilities and to invoke time stamping methods.  This patch adds a
> functional interface around the time stamping fields.  This will allow
> insulating the callers from future changes to the details of the time
> stamping implemenation.
> 
> Signed-off-by: Richard Cochran <richardcochran@...il.com>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Ideally we may even add locking annotations to make sure that there
there is no use after free in that the test is true, you de-reference
the PHY device and/or driver method, and boom. All callers appear to be
under RTNL right now.
-- 
Florian