netdev - Re: [PATCH, net-next, v3, 0/2] net/ethtool: Introduce link_ksettings API for virtual network devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191220.145352.754139742452100943.davem@davemloft.net>
Date:   Fri, 20 Dec 2019 14:53:52 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     stephen@...workplumber.org
Cc:     cforno12@...ux.vnet.ibm.com, netdev@...r.kernel.org,
        mst@...hat.com, jasowang@...hat.com, haiyangz@...rosoft.com,
        sthemmin@...rosoft.com, sashal@...nel.org, tlfalcon@...ux.ibm.com
Subject: Re: [PATCH, net-next, v3, 0/2] net/ethtool: Introduce
 link_ksettings API for virtual network devices

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Thu, 19 Dec 2019 19:29:09 -0800

> On Thu, 19 Dec 2019 14:16:19 -0800 (PST)
> David Miller <davem@...emloft.net> wrote:
> 
>> From: Stephen Hemminger <stephen@...workplumber.org>
>> Date: Thu, 19 Dec 2019 13:11:56 -0800
>> 
>> > I don't think this makes sense for netvsc. The speed and duplex have no
>> > meaning, why do you want to allow overriding it? If this is to try and make
>> > some dashboard look good; then you aren't seeing the real speed which is
>> > what only the host knows. Plus it does take into account the accelerated
>> > networking path.  
>> 
>> Maybe that's the point, userspace has extraneous knowledge it might
>> use to set it accurately.
>> 
>> This helps for bonding/team etc. as well.
>> 
>> I don't think there is any real harm in allowing to set this, and
>> we've done this in the past I think.
> 
> My preference would be to have host report some real data.
> But that might take host side changes which have a long lead time to
> get done.

_Iff_ they ever get done.

Meanwhile... we should provide some way to address this in the short
term.