netdev - Re: [PATCH] NFC: pn544: Adjust indentation in pn544_hci_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Dec 2019 18:14:12 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     natechancellor@...il.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        clang-built-linux@...glegroups.com
Subject: Re: [PATCH] NFC: pn544: Adjust indentation in
 pn544_hci_check_presence

From: Nathan Chancellor <natechancellor@...il.com>
Date: Tue, 17 Dec 2019 18:21:52 -0700

> Clang warns
> 
> ../drivers/nfc/pn544/pn544.c:696:4: warning: misleading indentation;
> statement is not part of the previous 'if' [-Wmisleading-indentation]
>                  return nfc_hci_send_cmd(hdev, NFC_HCI_RF_READER_A_GATE,
>                  ^
> ../drivers/nfc/pn544/pn544.c:692:3: note: previous statement is here
>                 if (target->nfcid1_len != 4 && target->nfcid1_len != 7 &&
>                 ^
> 1 warning generated.
> 
> This warning occurs because there is a space after the tab on this line.
> Remove it so that the indentation is consistent with the Linux kernel
> coding style and clang no longer warns.
> 
> Fixes: da052850b911 ("NFC: Add pn544 presence check for different targets")
> Link: https://github.com/ClangBuiltLinux/linux/issues/814
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Applied to net-next, thanks.