netdev - Re: [PATCH net v2] mod_devicetable: fix PHY module format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31fc357c-2e50-beaf-5a88-4e6dac40d7ad@gmail.com>
Date:   Thu, 19 Dec 2019 19:57:29 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Russell King <rmk+kernel@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Andy Fleming <afleming@...escale.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Ben Hutchings <ben@...adent.org.uk>
Subject: Re: [PATCH net v2] mod_devicetable: fix PHY module format



On 12/19/2019 3:24 PM, Russell King wrote:
> When a PHY is probed, if the top bit is set, we end up requesting a
> module with the string "mdio:-10101110000000100101000101010001" -
> the top bit is printed to a signed -1 value. This leads to the module
> not being loaded.
> 
> Fix the module format string and the macro generating the values for
> it to ensure that we only print unsigned types and the top bit is
> always 0/1. We correctly end up with
> "mdio:10101110000000100101000101010001".
> 
> Fixes: 8626d3b43280 ("phylib: Support phy module autoloading")
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian