netdev - Re: [PATCH v2 net-next 1/1] ptp: clockmatrix: Rework clockmatrix version information.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191220.211733.1421052503969423092.davem@davemloft.net>
Date:   Fri, 20 Dec 2019 21:17:33 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     vincent.cheng.xh@...esas.com
Cc:     robh+dt@...nel.org, mark.rutland@....com, richardcochran@...il.com,
        devicetree@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net-next 1/1] ptp: clockmatrix: Rework clockmatrix
 version information.

From: vincent.cheng.xh@...esas.com
Date: Wed, 18 Dec 2019 22:21:37 -0500

> From: Vincent Cheng <vincent.cheng.xh@...esas.com>
> 
> Remove pipeline id, bond id, csr id, and irq id.
> Changes source register for reading HW rev id.
> Add OTP config select.
> 
> Signed-off-by: Vincent Cheng <vincent.cheng.xh@...esas.com>

Nothing in this commit message explains why this change is being made.

What is wrong with the existing version code?  What is better about the
new code?

You always must explain why a change is being made and give as much
information and details and background as possible.

Thank you.