netdev - Re: [PATCH net] hv_netvsc: Fix unwanted rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191220.215048.1634942767816580703.davem@davemloft.net>
Date:   Fri, 20 Dec 2019 21:50:48 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     haiyangz@...rosoft.com
Cc:     sashal@...nel.org, linux-hyperv@...r.kernel.org,
        netdev@...r.kernel.org, kys@...rosoft.com, sthemmin@...rosoft.com,
        olaf@...fle.de, vkuznets@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] hv_netvsc: Fix unwanted rx_table reset

From: Haiyang Zhang <haiyangz@...rosoft.com>
Date: Thu, 19 Dec 2019 18:28:10 -0800

> In existing code, the receive indirection table, rx_table, is in
> struct rndis_device, which will be reset when changing MTU, ringparam,
> etc. User configured receive indirection table values will be lost.
> 
> To fix this, move rx_table to struct net_device_context, and check
> netif_is_rxfh_configured(), so rx_table will be set to default only
> if no user configured value.
> 
> Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table")
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>

Applied.