netdev - Re: [PATCH net-next v5 1/3] net: skb_mpls_push() modified to allow MPLS header push at start of packet.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_CpxF5zaaVdsf9wrLmNjaFbEzf8tacUio4SZGJ84nxNCQ@mail.gmail.com>
Date:   Sat, 21 Dec 2019 09:25:28 -0800
From:   Pravin Shelar <pshelar@....org>
To:     Martin Varghese <martinvarghesenokia@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>, scott.drennan@...ia.com,
        Jiri Benc <jbenc@...hat.com>,
        "Varghese, Martin (Nokia - IN/Bangalore)" <martin.varghese@...ia.com>
Subject: Re: [PATCH net-next v5 1/3] net: skb_mpls_push() modified to allow
 MPLS header push at start of packet.

On Fri, Dec 20, 2019 at 7:21 PM Martin Varghese
<martinvarghesenokia@...il.com> wrote:
>
> From: Martin Varghese <martin.varghese@...ia.com>
>
> The existing skb_mpls_push() implementation always inserts mpls header
> after the mac header. L2 VPN use cases requires MPLS header to be
> inserted before the ethernet header as the ethernet packet gets tunnelled
> inside MPLS header in those cases.
>
> Signed-off-by: Martin Varghese <martin.varghese@...ia.com>
> ---
> Changes in v2:
>     - Fixed comments section of skb_mpls_push().
>     - Added skb_reset_mac_len() in skb_mpls_push(). The mac len changes
>       when MPLS header in inserted at the start of the packet.
>
>  net/core/skbuff.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
Acked-by: Pravin B Shelar <pshelar@....org>

Thanks.