[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191221183842.GC7352@linux.home>
Date: Sat, 21 Dec 2019 19:38:42 +0100
From: Guillaume Nault <gnault@...hat.com>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, Julian Anastasov <ja@....bg>,
Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
David Ahern <dsahern@...il.com>,
Eric Dumazet <edumazet@...gle.com>,
David Miller <davem@...emloft.net>,
Pablo Neira <pablo@...filter.org>,
Stephen Hemminger <stephen@...workplumber.org>,
Alexey Kodanev <alexey.kodanev@...cle.com>
Subject: Re: [PATCHv4 net 8/8] net/dst: do not confirm neighbor for vxlan and
geneve pmtu update
On Fri, Dec 20, 2019 at 11:25:25AM +0800, Hangbin Liu wrote:
> When do IPv6 tunnel PMTU update and calls __ip6_rt_update_pmtu() in the end,
> we should not call dst_confirm_neigh() as there is no two-way communication.
>
> So disable the neigh confirm for vxlan and geneve pmtu update.
>
> v4: No change.
> v3: Do not remove dst_confirm_neigh, but add a new bool parameter in
> dst_ops.update_pmtu to control whether we should do neighbor confirm.
> Also split the big patch to small ones for each area.
> v2: Remove dst_confirm_neigh in __ip6_rt_update_pmtu.
>
> Fixes: a93bf0ff4490 ("vxlan: update skb dst pmtu on tx path")
> Fixes: 52a589d51f10 ("geneve: update skb dst pmtu on tx path")
> Reviewed-by: Guillaume Nault <gnault@...hat.com>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
> include/net/dst.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/dst.h b/include/net/dst.h
> index 208e7c0c89d8..626cf614ad86 100644
> --- a/include/net/dst.h
> +++ b/include/net/dst.h
> @@ -535,7 +535,7 @@ static inline void skb_tunnel_check_pmtu(struct sk_buff *skb,
> u32 encap_mtu = dst_mtu(encap_dst);
>
> if (skb->len > encap_mtu - headroom)
> - skb_dst_update_pmtu(skb, encap_mtu - headroom);
> + skb_dst_update_pmtu_no_confirm(skb, encap_mtu - headroom);
> }
>
Tested-by: Guillaume Nault <gnault@...hat.com>
Powered by blists - more mailing lists