netdev - Re: [jkirsher-net-queue:dev-queue 5/5] drivers/net/ethernet/intel/e1000e/netdev.c:7604:7: warning: address of function 'down' will always evaluate to 'true'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191222032542.GA44059@ubuntu-m2-xlarge-x86>
Date:   Sat, 21 Dec 2019 20:25:42 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     kbuild@...ts.01.org, Nick Desaulniers <ndesaulniers@...gle.com>,
        clang-built-linux@...glegroups.com,
        kbuild test robot <lkp@...el.com>, netdev@...r.kernel.org
Subject: Re: [jkirsher-net-queue:dev-queue 5/5]
 drivers/net/ethernet/intel/e1000e/netdev.c:7604:7: warning: address of
 function 'down' will always evaluate to 'true'

Hi Jeff,

We received this build report from the 0day team with clang, seems
legit. Mind taking a look into it?

Cheers,
Nathan

On Sun, Dec 22, 2019 at 03:36:15AM +0800, kbuild test robot wrote:
> CC: kbuild-all@...ts.01.org
> CC: intel-wired-lan@...ts.osuosl.org
> TO: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-queue.git dev-queue
> head:   831655569c70675c1622f8c52ed271dc7fdce42f
> commit: 831655569c70675c1622f8c52ed271dc7fdce42f [5/5] e1000e: Revert "e1000e: Make watchdog use delayed work"
> config: arm64-defconfig (attached as .config)
> compiler: clang version 10.0.0 (git://gitmirror/llvm_project 3ced23976aa8a86a17017c87821c873b4ca80bc2)
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 831655569c70675c1622f8c52ed271dc7fdce42f
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm64 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@...el.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/net/ethernet/intel/e1000e/netdev.c:7604:7: warning: address of function 'down' will always evaluate to 'true' [-Wpointer-bool-conversion]
>            if (!down)
>                ~^~~~
>    drivers/net/ethernet/intel/e1000e/netdev.c:7604:7: note: prefix with the address-of operator to silence this warning
>            if (!down)
>                 ^
>                 &
>    1 warning generated.
> 
> vim +7604 drivers/net/ethernet/intel/e1000e/netdev.c
> 
>   7584	
>   7585	/**
>   7586	 * e1000_remove - Device Removal Routine
>   7587	 * @pdev: PCI device information struct
>   7588	 *
>   7589	 * e1000_remove is called by the PCI subsystem to alert the driver
>   7590	 * that it should release a PCI device.  The could be caused by a
>   7591	 * Hot-Plug event, or because the driver is going to be removed from
>   7592	 * memory.
>   7593	 **/
>   7594	static void e1000_remove(struct pci_dev *pdev)
>   7595	{
>   7596		struct net_device *netdev = pci_get_drvdata(pdev);
>   7597		struct e1000_adapter *adapter = netdev_priv(netdev);
>   7598	
>   7599		e1000e_ptp_remove(adapter);
>   7600	
>   7601		/* The timers may be rescheduled, so explicitly disable them
>   7602		 * from being rescheduled.
>   7603		 */
> > 7604		if (!down)
>   7605			set_bit(__E1000_DOWN, &adapter->state);
>   7606		del_timer_sync(&adapter->watchdog_timer);
>   7607		del_timer_sync(&adapter->phy_info_timer);
>   7608	
>   7609		cancel_work_sync(&adapter->reset_task);
>   7610		cancel_work_sync(&adapter->watchdog_task);
>   7611		cancel_work_sync(&adapter->downshift_task);
>   7612		cancel_work_sync(&adapter->update_phy_task);
>   7613		cancel_work_sync(&adapter->print_hang_task);
>   7614	
>   7615		if (adapter->flags & FLAG_HAS_HW_TIMESTAMP) {
>   7616			cancel_work_sync(&adapter->tx_hwtstamp_work);
>   7617			if (adapter->tx_hwtstamp_skb) {
>   7618				dev_consume_skb_any(adapter->tx_hwtstamp_skb);
>   7619				adapter->tx_hwtstamp_skb = NULL;
>   7620			}
>   7621		}
>   7622	
>   7623		unregister_netdev(netdev);
>   7624	
>   7625		if (pci_dev_run_wake(pdev))
>   7626			pm_runtime_get_noresume(&pdev->dev);
>   7627	
>   7628		/* Release control of h/w to f/w.  If f/w is AMT enabled, this
>   7629		 * would have already happened in close and is redundant.
>   7630		 */
>   7631		e1000e_release_hw_control(adapter);
>   7632	
>   7633		e1000e_reset_interrupt_capability(adapter);
>   7634		kfree(adapter->tx_ring);
>   7635		kfree(adapter->rx_ring);
>   7636	
>   7637		iounmap(adapter->hw.hw_addr);
>   7638		if ((adapter->hw.flash_address) &&
>   7639		    (adapter->hw.mac.type < e1000_pch_spt))
>   7640			iounmap(adapter->hw.flash_address);
>   7641		pci_release_mem_regions(pdev);
>   7642	
>   7643		free_netdev(netdev);
>   7644	
>   7645		/* AER disable */
>   7646		pci_disable_pcie_error_reporting(pdev);
>   7647	
>   7648		pci_disable_device(pdev);
>   7649	}
>   7650	
> 
> ---
> 0-DAY kernel test infrastructure                 Open Source Technology Center
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
> 
> -- 
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/201912220313.FgL3fS3o%25lkp%40intel.com.