netdev - Re: [PATCH V8 net-next 06/12] net: phy: dp83640: Move the probe and remove methods around.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191223091205.GE32356@lunn.ch>
Date:   Mon, 23 Dec 2019 10:12:05 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Richard Cochran <richardcochran@...il.com>
Cc:     netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
        devicetree@...r.kernel.org,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Mark Rutland <mark.rutland@....com>,
        Miroslav Lichvar <mlichvar@...hat.com>,
        Murali Karicheri <m-karicheri2@...com>,
        Rob Herring <robh+dt@...nel.org>,
        Willem de Bruijn <willemb@...gle.com>,
        Wingman Kwok <w-kwok2@...com>
Subject: Re: [PATCH V8 net-next 06/12] net: phy: dp83640: Move the probe and
 remove methods around.

On Sat, Dec 21, 2019 at 11:36:32AM -0800, Richard Cochran wrote:
> An upcoming patch will change how the PHY time stamping functions are
> registered with the networking stack, and adapting this driver would
> entail adding forward declarations for four time stamping methods.
> However, forward declarations are considered to be stylistic defects.
> This patch avoids the issue by moving the probe and remove methods
> immediately above the phy_driver interface structure.
> 
> Signed-off-by: Richard Cochran <richardcochran@...il.com>

Hi Richard

Thanks for adding this.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew