lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Dec 2019 15:03:24 +0100 From: Julian Wiedmann <jwi@...ux.ibm.com> To: David Miller <davem@...emloft.net> Cc: <netdev@...r.kernel.org>, <linux-s390@...r.kernel.org>, Heiko Carstens <heiko.carstens@...ibm.com>, Stefan Raspl <raspl@...ux.ibm.com>, Ursula Braun <ubraun@...ux.ibm.com>, Alexandra Winter <wintera@...ux.ibm.com>, Julian Wiedmann <jwi@...ux.ibm.com> Subject: [PATCH net 4/6] s390/qeth: Fix vnicc_is_in_use if rx_bcast not set From: Alexandra Winter <wintera@...ux.ibm.com> Symptom: After vnicc/rx_bcast has been manually set to 0, bridge_* sysfs parameters can still be set or written. Only occurs on HiperSockets, as OSA doesn't support changing rx_bcast. Vnic characteristics and bridgeport settings are mutually exclusive. rx_bcast defaults to 1, so manually setting it to 0 should disable bridge_* parameters. Instead it makes sense here to check the supported mask. If the card does not support vnicc at all, bridge commands are always allowed. Fixes: caa1f0b10d18 ("s390/qeth: add VNICC enable/disable support") Signed-off-by: Alexandra Winter <wintera@...ux.ibm.com> Signed-off-by: Julian Wiedmann <jwi@...ux.ibm.com> --- drivers/s390/net/qeth_l2_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/s390/net/qeth_l2_main.c index fc5d8ed3a737..8024a2112a87 100644 --- a/drivers/s390/net/qeth_l2_main.c +++ b/drivers/s390/net/qeth_l2_main.c @@ -1952,8 +1952,7 @@ int qeth_l2_vnicc_get_timeout(struct qeth_card *card, u32 *timeout) /* check if VNICC is currently enabled */ bool qeth_l2_vnicc_is_in_use(struct qeth_card *card) { - /* if everything is turned off, VNICC is not active */ - if (!card->options.vnicc.cur_chars) + if (!card->options.vnicc.sup_chars) return false; /* default values are only OK if rx_bcast was not enabled by user * or the card is offline. -- 2.17.1
Powered by blists - more mailing lists